eeditiones / tei-publisher-app

The main TEI Publisher app
https://teipublisher.com
GNU General Public License v3.0
68 stars 33 forks source link

[fix] head elements in a list element are omitted #119

Closed ccheraa closed 2 years ago

ccheraa commented 2 years ago

Currently only item elements in a list are rendered, this will include head elements too

fixes #118

This open source contribution to the tei-publisher-app project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.

ccheraa commented 2 years ago

I still think this should be fixed, if you look at the ODD, it says the head element should be rendered as a block if its parent is a list element: https://github.com/eeditiones/tei-publisher-app/blob/3d38420603d672c37bb08259f71253e2125b2f4c/odd/tei_simplePrint.odd#L4516-L4526

And it says that only item elements should be rendered under a list element: https://github.com/eeditiones/tei-publisher-app/blob/3d38420603d672c37bb08259f71253e2125b2f4c/odd/tei_simplePrint.odd#L4580-L4587

Which means we will never have a list element that's a parent of a head element, which makes the first mentioned model irrelevant.

So if omitting head elements is intended, then the model about rendering head elements under list elements should be removed.

duncdrum commented 2 years ago

all good points, but such changes need to be implemented by the tei folks who are the authors of the tei_simplePrint.odd. PRs need to go to them, tei-publisher is only a user library that includes the ODD provided by the TEI council.

wolfgangmm commented 2 years ago

tei_simplePrint.odd certainly is in need for a review, but this needs coordination and for the time being, we use it as is. tei-publisher.odd extends it and corrects the obvious mistakes. So your change should go there.