eeditiones / tei-publisher-app

The main TEI Publisher app
https://teipublisher.com
GNU General Public License v3.0
68 stars 33 forks source link

Tp8 docker maintenance #149

Closed duncdrum closed 1 year ago

duncdrum commented 1 year ago

Version updates to various dependencies in devcontainer and dockerfile.

Switch to duncdrum/existdb base image in Dockerfile, currently install DEMO apps from open PRs for compatibility see https://github.com/eeditiones/shakespeare/pull/8 see https://github.com/eeditiones/vangogh/pull/2

Use J8 instead of J17 for exist 6.2.0

streamlined and updated GitHub action scripts

for a dry run see https://github.com/eeditiones/tei-publisher-ner/pull/4

close https://github.com/eeditiones/tei-publisher-planning/issues/36

Going to take a look at the Docker-compose now see https://github.com/eeditiones/teipublisher-docker-compose/issues/5 see https://github.com/eeditiones/teipublisher-docker-compose/issues/4

Please test both devcontainers and dockerfiles for your workflows.

Changes: no more shell (could switch to debug images for that) automatic updates of stock expaths app inside existdb on top of os and java updates switched from alpine to Debian for greater consistency ADMIN_PASS clear text variable no longer in use multi-arch builds for arm and intel

duncdrum commented 1 year ago

the changes to the GitHub action script are meant to maintain previous behaviour. We will only see it in action properly with the release though, with a new git tag, on master, new registry, etc.

There are a number of questions do we want to target raspberry pi in addition to what we have now? do we ant to add more tags eg for branches or prs? do we want to add additional labels (or any), do we want to stick with only publishing from master branch?

I m not a big fan of the master tag being updated for every push to master, but latest sticking with a static version of the last full release. But changing this might create more headaches than it solves.

Do we want to change the image name to editions/teipublisher?