eeditiones / tei-publisher-components

Web components used by TEI Publisher and apps generated by it
https://cdn.tei-publisher.com/
GNU General Public License v3.0
18 stars 14 forks source link

Pb facsimile #118

Closed JoernT closed 1 year ago

JoernT commented 1 year ago

fixes https://github.com/orgs/eeditiones/projects/1/views/1?pane=issue&itemId=22122804

OSD standard dist removes the content of the body element when full-screen is triggered. This disconnects all event llisteners from the DOM that is later inserted again when OSD closes full screen.

To fix the issues a patch to OSD is required that instead of removing all elements these are only hidden. It shoud be mentioned that their source code mentions an issue with IPad as reason for them doing so. However this breaks it for all other devices also so this limitation is the lesser pain. However test on IPad should be done at some point.

The solution is based on the assumption that there is a pb-page element and it essentially covers the viewport. A more generic approach would require some more work.

JoernT commented 1 year ago

this wasn't properly prepared