toggle-feature and select-feature cause errors reloading the page

[tuurma]

Selecting configuration with pb-toggle-feature or pb-select-feature adjusts the URL to include selectors=.... section which prevents the page from being reloaded correctly

Compare

https://teipublisher.com/exist/apps/tei-publisher/test/lelewel1.xml?view=page&norm=off&odd=lelewel

vs

https://teipublisher.com/exist/apps/tei-publisher/test/lelewel1.xml?view=page&norm=on&odd=lelewel&selectors=%5Bobject+Object%5D

[line-o]

I was able to reproduce the incorrect URL by clicking the "Normalised View" checkbox in the top toolbar.

[line-o]

I found the code that is responsible for adding the selectors to the URL. It is PbView.toggleFeature(ev).

registry.getState(this) will return the array of selectors among all other properties. These properties are then used in a call to registry.commit() which adds the selectors to the URL.

[line-o]

By simply removing the selectors from the properties before calling registry.commit() does keep the URL clean and the state can be toggled.

        // shield URL from selectors
        delete properties.selectors

[line-o]

Side note: Initial toggle states are not picked up properly in the client-side demo.

[line-o]

The selectors property is sometimes stored in state and sometimes only in channelState from what I gather.

[line-o]

related https://github.com/eeditiones/tei-publisher-components/issues/149