eeditiones / tei-publisher-components

Web components used by TEI Publisher and apps generated by it
https://cdn.tei-publisher.com/
GNU General Public License v3.0
18 stars 14 forks source link

Allow multiple groups in pb-login #170

Closed daliboris closed 7 months ago

daliboris commented 9 months ago

Current implementation allows only one group to be specified in pb-login component.

This change allows multple groups in pb-login, for example tei and quest.

Groups are separated items by space and/or punctuation.

This change doesn't break existing implementations.

daliboris commented 8 months ago

Yes, thank you.

I prefer a space and a comma because the value of the group property is displayed in the dialog when the login is not successful.

The warning message looks like a natural sentence if the groups are separated by a comma followed by a space.

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 2.15.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: