eeditiones / tei-publisher-components

Web components used by TEI Publisher and apps generated by it
https://cdn.tei-publisher.com/
GNU General Public License v3.0
18 stars 14 forks source link

incorrect request sent from pb-search with pb-select and pb-autocomplete #18

Closed tuurma closed 4 years ago

tuurma commented 4 years ago

Problem

request send the parameters for nested pb-select/pb-autocomplete duplicated in a comma separated list e.g. searching for strint types in document kabul sends

query=types&doc=kabul,kabul,

pb-select

<pb-search action="${app}/search.html" data-template="pages:parse-params" value="${query}" redirect="redirect">
      <pb-select source="modules/autocomplete.xql?query=k" name="doc" label="search in"/>
</pb-search>

request sent for query=types and doc=kabul

search.html?query=types&autocomplete-custom-template=undefined&doc=kabul%2Ckabul%2C instead of expected search.html?query=types&doc=kabul

pb-autocomplete

<pb-search action="${app}/search.html" data-template="pages:parse-params" value="${query}" redirect="redirect">
       <pb-autocomplete source="modules/autocomplete.xql" name="doc" label="search in"/>
</pb-search>

request sent for query=types and doc=kabul

search.html?query=types&autocomplete-custom-template=undefined&doc=kabul%2C instead of expected search.html?query=types&doc=kabul

for comparison, a construct with a generic form sends a correct expected request

<form id="form" action="${app}/search.html" data-template="pages:parse-params">
       <pb-autocomplete label="Enter Query" source="modules/autocomplete.xql" name="query"/>
        <pb-select source="modules/autocomplete.xql?query=k" name="doc" label="search in"/>
        <input type="submit"></input>
</form>
tuurma commented 4 years ago

Results of discussion this morning: looks like iron-form is the culprit for superfluous controls

image

tuurma commented 4 years ago

fixed in bugfix/i18n