search

eeeeaaii / vodka

Creative Coding Environment
GNU General Public License v3.0
126 stars 3 forks source link

set default insertion pip after editing a command #121

Open eeeeaaii opened 3 years ago

eeeeaaii commented 3 years ago

we have logic for commands that moves the default insertion pip to after a command if it has no args.

However it's not really clear when we actually run this code to set the pip. maybe when it's selected?

We should run it then I guess, but ALSO immediately after editing the command - i.e. after that command name has been chosen and the editor finishes

eeeeaaii commented 3 years ago

erm I guess we would only do this if the insertion pip was inside - and it was changed to a command type that doesn't have an argument.

It seems like this could actually be a different FR - maybe commands without args should be

  1. displayed differently
  2. not allow you to add children to them

of course what happens when you have a command that has children and you accidentally change the name of the command to "random" - does it delete the children?

needs further thought and maybe this can just stay the way it is.

eeeeaaii commented 2 years ago

closing as WAI, this old bug is out of date