search

eelcohn / nRF905-API

API webinterface for the nRF905
MIT License
66 stars 20 forks source link

Finish HTTPS support in a future release #9

Open DevSecNinja opened 4 years ago

DevSecNinja commented 4 years ago

First of all: thanks for your great work! I ran into an issue when enabling HTTPS. When I set #define NRF905API_HTTPS from 0 to 1, I get the following error message:

<path>\nRF905-API\src\nRF905API\nRF905API.ino: In function 'void setup()':

nRF905API:194:54: error: 'serverCert' was not declared in this scope

  server.getServer().setRSACert(new BearSSL::X509List(serverCert), new BearSSL::PrivateKey(serverKey));

                                                      ^

nRF905API:194:91: error: 'serverKey' was not declared in this scope

  server.getServer().setRSACert(new BearSSL::X509List(serverCert), new BearSSL::PrivateKey(serverKey));
                                                                                         ^
exit status 1
'serverCert' was not declared in this scope

When I change NRF905API_HTTPS back to 1, it compiles successfully.

eelcohn commented 4 years ago

That happens because I haven't finished HTTPS supoort yet :) I'll finish that in a future release (y)