eeliana / pe

0 stars 0 forks source link

Missing user story for overlapping appointments #19

Open eeliana opened 2 years ago

eeliana commented 2 years ago

GoMedic has a not insignificant feature of detecting clashes amongst existing appointments and the one that the user wishes to add but this is missing in the user stories for activities.

nus-pe-bot commented 2 years ago

Team's Response

Thank you for the response :) Overlapping appointments user story is categorized under adding an appointment. There is no and should not be any specific details included on how the adding the appointments should be implemented and hence we do not see the need to separate this into another user story.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Please refer to this issue addressed by Prof Damith: https://github.com/nus-cs2103-AY2122S1/forum/issues/407#issuecomment-968676269

Implementing the feature to add appointments is separate from the implementation of the feature to detect clashes between existing appointments and the ones being added. The detection of overlapping appointments is an extension to the adding of appointments/activities and therefore, should be differentiated and documented in the user stories. This is so that future developer can also know to maintain and improve this existing feature, should there be any bugs.

In fact, this feature for detecting clashes is not documented anywhere in the DG. I will consider it important for this feature to be documented since the team considered it important enough to be implemented. In this case, the bug for missing user stories with respect to the ability to be reminded of prior activities/appointments remains a valid concern. Therefore, I disagree with the team stance.