search

eepykate / fet.sh

🐢 a fetch written in posix shell without any external commands (sponsored by https://git.io/kiwmi)
https://github.com/buffet/kiwmi
ISC License
366 stars 22 forks source link

i3blocks is detected as WM #15

Closed MatthiasCoppens closed 4 years ago

MatthiasCoppens commented 4 years ago

In the WM case statement, i3blocks is considered to be a valid name:

https://github.com/6gk/fet.sh/pull/14 fixes it on my system, but that's only because I don't randomize my PIDs. If I were to do that, i3blocks would still show up as my WM 50% of the time.

elkowar commented 4 years ago

same thing will also happen with other things that start with a wm name (dwmblocks is a thing, right?)

eepykate commented 4 years ago

Hello, can you see if 0ac1b7d216e7fbd84d53d1789a7c2581ffb464a3 fixes it for you? Thanks.

eepykate commented 4 years ago

@elkowar I'm not sure about dwmblocks, but I had my borders script named 2bspwm for a bit and it detected that as the WM, so I undid the rename.

Sadly sh sorts stuff like 1 20 3 388 4 so it doesn't go from lowest PID to highest, sort has the -n option which fixes this, but that's not really a builtin so I can't use it.

MatthiasCoppens commented 4 years ago

Can confirm that https://github.com/6gk/fet.sh/commit/0ac1b7d216e7fbd84d53d1789a7c2581ffb464a3 fixes it on my end