BinFile maximum_address is actually pointing 1 byte "further"?

eerimoq / bincopy

Mangling of various file formats that conveys binary information (Motorola S-Record, Intel HEX, TI-TXT, Verilog VMEM, ELF and binary files).

MIT License

109 stars 38 forks source link

BinFile maximum_address is actually pointing 1 byte "further"? #18

Closed kwesolowski closed 4 years ago

kwesolowski commented 4 years ago

Not sure if its "an issue" in code, naming or just maybe lack of doc, but maximum_address not maximum address of given file/segment, its behaves closer to end iterator (pointing 1 byte after last one?)

eerimoq commented 4 years ago

Yes, exactly, the idea is that it should mimic iterators.

I updated the documentation. Better now?

eerimoq commented 4 years ago

I guess so...