search

eerimoq / bincopy

Mangling of various file formats that conveys binary information (Motorola S-Record, Intel HEX, TI-TXT, Verilog VMEM, ELF and binary files).
MIT License
109 stars 38 forks source link

Fixing the __str__ function for Segment in python 3. #3

Closed willderness closed 8 years ago

willderness commented 8 years ago

Still works in python2 however in python3 byte arrays arent interchangable with strings (as easily)

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 80.409% when pulling 33bb06077da9ad0b9fb1360b957809554c5a460f on willderness:python3_str_fix into 5a969fccce9cdea8ec5bbcd962bec11e6cc3bb43 on eerimoq:master.

eerimoq commented 8 years ago

Hello,

Sorry for the late response. I'm on vacation and will accept the pull request when I'm back home next week.

Can you add a test case that calls the __str__() function?

Erik

eerimoq commented 8 years ago

I merged the change and added a testcase.

Thanks for your support!

willderness commented 8 years ago

Awesome! Thanks for writing the tests!