eerimoq / bincopy

Mangling of various file formats that conveys binary information (Motorola S-Record, Intel HEX, TI-TXT, Verilog VMEM, ELF and binary files).
MIT License
109 stars 38 forks source link

17.14.3: Missing some test files in sdist tarball #33

Closed dvzrv closed 1 year ago

dvzrv commented 1 year ago

Hi! When trying to package 17.14.3 for Arch Linux I had two failing tests, as there are test files missing in the sdist tarball:

=================================== FAILURES ===================================
_______________________ BinCopyTest.test_add_elf_blinky ________________________

self = <tests.test_bincopy.BinCopyTest testMethod=test_add_elf_blinky>

    def test_add_elf_blinky(self):
        bf = bincopy.BinFile()
>       bf.add_elf_file('tests/files/evkbimxrt1050_iled_blinky_sdram.axf')

tests/test_bincopy.py:1777:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <bincopy.BinFile object at 0x7fa750e43e80>
filename = 'tests/files/evkbimxrt1050_iled_blinky_sdram.axf', overwrite = False

    def add_elf_file(self, filename, overwrite=False):
        """Open given ELF file and add its contents. Set `overwrite` to
        ``True`` to allow already added data to be overwritten.

        """

>       with open(filename, 'rb') as fin:
E       FileNotFoundError: [Errno 2] No such file or directory: 'tests/files/evkbimxrt1050_iled_blinky_sdram.axf'

bincopy.py:1161: FileNotFoundError
_________________________ BinCopyTest.test_add_elf_gcc _________________________

self = <tests.test_bincopy.BinCopyTest testMethod=test_add_elf_gcc>

    def test_add_elf_gcc(self):
        bf = bincopy.BinFile()
>       bf.add_elf_file('tests/files/elf/gcc.elf')

tests/test_bincopy.py:1788:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <bincopy.BinFile object at 0x7fa750e43ac0>
filename = 'tests/files/elf/gcc.elf', overwrite = False

    def add_elf_file(self, filename, overwrite=False):
        """Open given ELF file and add its contents. Set `overwrite` to
        ``True`` to allow already added data to be overwritten.

        """

>       with open(filename, 'rb') as fin:
E       FileNotFoundError: [Errno 2] No such file or directory: 'tests/files/elf/gcc.elf'

bincopy.py:1161: FileNotFoundError
=========================== short test summary info ============================
FAILED tests/test_bincopy.py::BinCopyTest::test_add_elf_blinky - FileNotFound...
FAILED tests/test_bincopy.py::BinCopyTest::test_add_elf_gcc - FileNotFoundErr...
========================= 2 failed, 91 passed in 1.22s =========================
eerimoq commented 1 year ago

Fixed in version 17.14.4.

eerimoq commented 1 year ago

@dvzrv does it work now?

dvzrv commented 1 year ago

Will try later today. Currently afk

-------- Original Message -------- From: Erik Moqvist @.> Sent: February 17, 2023 1:12:46 PM GMT+01:00 To: eerimoq/bincopy @.> Cc: David Runge @.>, Mention @.> Subject: Re: [eerimoq/bincopy] 17.14.3: Missing some test files in sdist tarball (Issue #33)

@dvzrv does it work now?

-- https://sleepmap.de

dvzrv commented 1 year ago

Thanks, 17.14.5 works as intended again! :)