search

eerimoq / detools

Binary delta encoding tools.
Other
157 stars 16 forks source link

Fix warnings when built without CRLE #1

Closed rgilton closed 4 years ago

rgilton commented 4 years ago

When building without CRLE, the functions unpack_usize_init and unpack_usize are not used, resulting in compiler warnings. This patch moves those functions into the DETOOLS_CONFIG_COMPRESSION_CRLE region so that these warnings are not generated when CRLE is disabled.

codecov[bot] commented 4 years ago

Codecov Report

Merging #1 into master will not change coverage. The diff coverage is 95.65%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files           5        5           
  Lines        1865     1865           
=======================================
  Hits         1745     1745           
  Misses        120      120
Impacted Files Coverage Δ
src/c/detools.c 92.63% <95.65%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b7b98b...0c2d367. Read the comment docs.

eerimoq commented 4 years ago

Thanks!

eerimoq commented 4 years ago

Btw, may I ask which compression algorithm you are planning to use?

rgilton commented 4 years ago

Sure -- heatshrink, because it performs quite well on the binaries I've shown it. I'd use lzma if I could find a library that used similarly small amounts of memory.

eerimoq commented 4 years ago

Ok, I added support for it for exactly that reason. I'm glad you found it useful.