search

eerne / scrollbar

MooTools Scrollbar class (extends Slider)
http://mild.ch/productslider
MIT License
29 stars 9 forks source link

Troubles in IE #10

Closed aschempp closed 12 years ago

aschempp commented 12 years ago

I've had some troubles in IE 8 (and probably others) where the position was not a number. For example this happens when creating the object, this.ratioScroll is not set and therefore the initialStep will cause an error when trying to position.

eerne commented 12 years ago

I setup a jsfiddle (http://jsfiddle.net/tofu/UYZZ6/) with current MooTools 1.4.4 and Scrollbar from master branch. How can I reproduce this issue?

eerne commented 12 years ago

Oh I see, IE8 doesn't like it at all :P Here an updated jsfiddle against your master http://jsfiddle.net/tofu/UYZZ6/1/ the problem now "move to element 1st" isn't scrolling the content area anymore.

aschempp commented 12 years ago

You're right. Maybe the condition should be >= 0 ?

aschempp commented 12 years ago

I've updated the pull request with >= 0, now it works for me.

eerne commented 12 years ago

Thanks aschempp