search

eerohele / saxon-gradle

A Gradle plugin for running XSLT transformations with Saxon
MIT License
16 stars 6 forks source link

Don't attempt to parse the stylesheet for includes and imports #25

Closed ndw closed 1 year ago

ndw commented 3 years ago

Per our discussion in #24, here's a PR that doesn't attempt to parse the stylesheet for include and import statements, but still allows it to be a URI. I've left in the attempt to choose an output filename extension by parsing for the xsl:output instruction, though I'm a little dubious of that as well.

eerohele commented 3 years ago

I've left in the attempt to choose an output filename extension by parsing for the xsl:output instruction, though I'm a little dubious of that as well.

Yes, that's another feature that's a bit too clever for its own good. I wouldn't implement it if I were making this plugin today.

In any case, thanks for all the effort you're making improving the plugin. I will do my best to look over these changes soon. Real life and other open-source work just keeps getting in the way, as it tends to do.

ndw commented 3 years ago

I understand. I have a version of it that I can publish if I need to get it into a couple of projects before you've had a chance to take a look. I've no real interest in maintaining a fork, but in the short term, if it gets the job done... :-)