DOCTYPE declaration issue

eerohele / saxon-gradle

A Gradle plugin for running XSLT transformations with Saxon

MIT License

16 stars 6 forks source link

Closed charlescrichton closed 8 years ago

charlescrichton commented 8 years ago

I have added a small fix to enable XSLTs with DOCTYPE declarations in them to work in src/main/groovy/com/github/eerohele/SaxonXsltTask.groovy.

Please consider pulling this into your code.

I have, locally to me, called this version version = '0.1.4-doctype-fix'. You will want to pick your own version number.

Thanks for providing this plugin. Very useful.

eerohele commented 8 years ago

Thanks for the PR! I'll merge this PR if you can:

[ ] Remove the version change from build.gradle
[ ] Remove the comment from SaxonXsltTask.groovy (this PR and the commit message is enough documentation for the change)
[ ] Rebase your change into a single commit

If you're busy, I can also manually cherry-pick the change and commit it myself.

eerohele commented 8 years ago

I've incorporated the change and released 0.1.4. Thanks again for the report!