search

eeshugerman / postgres-backup-s3

A handy Docker container to periodically backup PostgreSQL to S3
MIT License
485 stars 167 forks source link

Update README.md #27

Closed TeeWallz closed 1 year ago

TeeWallz commented 1 year ago

Hi, Love the docker container. In wanting to use S3 compatible storage, I looked into the backup file itself to see that custom S3 endpoints are already supported, but not documented in the README. I think that this feature is fantastic and deserve's it's place in the spotlight Creating a PR for a potential way to show this, however if you feel there's a better way of doing this, feel free to decline this PR Cheers

eeshugerman commented 1 year ago

Hi, thanks for pointing this out! I agree we should document S3_ENDPOINT. But I want to do it a bit differently than this, so I went ahead and did so in https://github.com/eeshugerman/postgres-backup-s3/commit/2564496912443dd69f125e8066fe8323d55fa915, along with a few other tweaks.