search

eeshugerman / postgres-backup-s3

A handy Docker container to periodically backup PostgreSQL to S3
MIT License
485 stars 167 forks source link

Support multiple databases through POSTGRES_DATABASE #47

Open schonert opened 9 months ago

schonert commented 9 months ago

Added support for multiple databases. I found schicklings approach pretty straightforward.

POSTGRES_DATABASE=database1,database2,database3.

Nothing has changed in how the database is backed up - simply allowing iterating over multiple. It could most likely be optimized - however, this is way better than having multiple docker containers running for different databases.

Simply copied the iterator from https://github.com/schickling/dockerfiles/blob/master/postgres-backup-s3/backup.sh

schonert commented 9 months ago

@eeshugerman, can I do anything to make this more straightforward for you to review/approve? :)

marcosviniciuscl commented 4 months ago

I really want this feature, can someone approve this pull request, please!!! @eeshugerman

purejamie commented 4 months ago

Hi @eeshugerman - any chance we can get this merged into base?

eeshugerman commented 4 months ago

Hi all, sorry about the lack of communication here. While I do intend to merge this (or something like it -- see also https://github.com/eeshugerman/postgres-backup-s3/pull/38) eventually, I can't give any timeframe commitments. I want to get integration tests in place before merging any more features, and I'm not sure when I'll get to that. In the meantime, I encourage forking the project if you really need this.

schonert commented 4 months ago

Totally fair :-) Planed out how you'd like to do tests or would you be interested in a PR from the community?

I'm afraid I wouldn't have a clue at this point - just in case someone why did, came along and saved our lost sounds