search

eeucalyptus / ch32v003-temperature

Using the ch32v003 as a temperature sensor
MIT License
17 stars 1 forks source link

Grammar tweaks - Update README.md #1

Open robertlipe opened 1 year ago

robertlipe commented 1 year ago

Thank you for a great article based on an interesting idea.

I hit some speed bumps while reading this, so I took a few moments to help make the English more consistent and correct. Mostly it's typos with a few things like making the items in a list consistently starting with verbs, for example.

Feel free to take or reject any part of this, of course.

Enjoy!

eeucalyptus commented 12 months ago

Haha I didn't expect that kind of feedback but thank you for the time and input, I'll look into it tonight :)

robertlipe commented 12 months ago

Open source is the work of many, right? It was hard for me to read, so I knocked off the sharp edges. Some are just typos. Some are just subtle rules of English like not starting a paragraph with "then" . There are actually rules https://englishrecap.com/can-you-start-a-sentence-with-then/ about such things....yet there are a ton of native English speakers in the U.S. that will screw that up. :-) So I'm happy to help.

I'm above average at English, but I'd have never had the creativity or the background to have pulled this trick off. I dig the WCH part and while I don't need a thermometer in them, I'm impressed as hell at this kind of thinking.

Thanx!

On Tue, Nov 7, 2023 at 2:39 AM eeucalyptus @.***> wrote:

Haha I didn't expect that kind of feedback but thank you for the time and input, I'll look into it tonight :)

— Reply to this email directly, view it on GitHub https://github.com/eeucalyptus/ch32v003-temperature/pull/1#issuecomment-1798043232, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD34AA2KGQC6JR2GXJQDYDHXUFAVCNFSM6AAAAAA7ALGVFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGA2DGMRTGI . You are receiving this because you authored the thread.Message ID: @.***>