eevansx / glcd-arduino

Automatically exported from code.google.com/p/glcd-arduino
0 stars 0 forks source link

Running bitmap utilty breaks GLCDdemo and GLCD_BigDemo example sketches #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There is an combination "bug" related to the bitmaps/allBitmaps.h
The allBitmaps.h file "as shipped" right now does not contain includes
for all the bitmaps in the bitmaps directory.
Most notably, the file "ArduinoIcon.h" is not included.
This file has a #define in it to map the name ArduinoIcon to ArduinoIcon64x64
This was done for backwards compatibility.
The "combination bug" comes into play as follows:

Once the user runs the Processing/Java bitmap utility, the allBitmaps.h file is 
updated to include all the headers in the bitmaps directory, which includes 
ArduinoIcon.h
This is normally not a problem and is in fact exactly what is desired.

However,
GLCDdemo.pde sketch has declaration of
Image_t ArduinoIcon;

Once ArduinoIcon.h is included, the demo code will no longer compile
and once the processing/java bitmap utility is run, the file ArduinoIcon.h is 
included because the allBitmaps.h header is udpated to include it.

I'm not quite sure how you want to handle it.
We have a couple of options.

1) We could "deprecate" ArduinoIcon and eliminate the include file in 
   the bitmaps directory and handle its definition in the
   include/glcd_Deprecated.h
   (This option requires updating some doxygen documentation)

2) Fix the demo code (GLCDdemo & GLCD_BigDemo) not use the variable name 
"ArduinoIcon".
   Simply change the name to something like "Icon" instead.
   Very quick/easy and solves the problem.

NOTE:
  While we are fixing this, we also should fix the allBitmaps.h file to
  include all the bitmap header files being shipped.

Original issue reported on code.google.com by bperry...@gmail.com on 24 Mar 2011 at 6:58

GoogleCodeExporter commented 9 years ago
This appears to have been resolved right away way back in revision r383
(originally entered on old repository as issue 54 on Jun 15, 2010, and fixed on 
June 16, 2010 in revision r383)

Original comment by bperry...@gmail.com on 26 Mar 2011 at 5:54