eeyhsong / EEG-Conformer

EEG Transformer 2.0. i. Convolutional Transformer for EEG Decoding. ii. Novel visualization - Class Activation Topography.
GNU General Public License v3.0
389 stars 55 forks source link

Intentionally Calculating this for each forward ?? #28

Closed vamsikumbuf closed 4 months ago

vamsikumbuf commented 6 months ago

https://github.com/eeyhsong/EEG-Conformer/blob/f17667d33671725666437b3e447e4363de4a3bce/conformer.py#L115

Here scaling variable is calculated for every forward loop, is this intentional otherwise this can be kept inside the init function right?

eeyhsong commented 4 months ago

Thanks for your suggestion, it's really a fixed value.