eez-open / modular-psu-firmware

Firmware for EEZ Bench Box 3 (BB3)
https://www.envox.eu/eez-bb3/
GNU General Public License v3.0
94 stars 42 forks source link

Limits on function generator values are not properly enforced/set. #228

Closed fietser28 closed 3 years ago

fietser28 commented 3 years ago

On FW 1.7-RC1: When entering the amplitude or offset in the function generator it is possible to input impossible values/combinations.

The Min. / Max. ranges are properly checked and generate a warning on the DCP405 module. On the DCM220 this also creates impossible values (outside the range of the module).

In general each channel has an absolute min (Cmin) - max (Cmax) range. When you enter:

Comparable rules apply to min/max.

I did not check this with SCPI commands. I also didn't turn the channels on with these values.

FG-limits1 FG-limits2 FG-limits3

prasimix commented 3 years ago

"Impossible values" will results with error on start indicating that voltage, current or power limits have been exceeded.

fietser28 commented 3 years ago

Fixed.