ef-labs / stash-hook-mirror

An Atlassian Stash repository hook for mirroring to one or more remote git repositories.
MIT License
77 stars 58 forks source link

Change dependency stash-scm-git to scope provided #12

Closed adrianluisgonzalez closed 11 years ago

adrianluisgonzalez commented 11 years ago

From Thomas B at Atlassian:

We saw some errors in a customers logs and have identified an issue with your plugin. It seems you are pulling in the stash-scm-git plugin into your jar.

Your pom has:

<dependency>
            <groupId>com.atlassian.stash</groupId>
            <artifactId>stash-scm-git</artifactId>
</dependency>

Whereas it should be:

<dependency>
            <groupId>com.atlassian.stash</groupId>
            <artifactId>stash-scm-git</artifactId>
            <scope>provided</scope>
</dependency>

This causes errors for users who are not running the version of Stash you compiled your plugin against.