search

ef-labs / vertx-elasticsearch-service

Vert.x elasticsearch service with event bus proxying
57 stars 18 forks source link

Add rx-java support #20

Open newoga opened 9 years ago

newoga commented 9 years ago

Hey @adrianluisgonzalez, any objections to adding vertx-rx-java support?

We could make it optional like you did with vertx-js

<dependency>
    <groupId>io.vertx</groupId>
    <artifactId>vertx-rx-java</artifactId>
    <version>${vertx.version}</version>
    <optional>true</optional>
</dependency>
adrianluisgonzalez commented 9 years ago

As long as it is optional and any rx functionality is clearly separated into an rx package then it sounds fine to me.

Cheers, -Adrian

On Oct 19, 2015, at 2:21 PM, Neil Gabbadon notifications@github.com wrote:

Hey @adrianluisgonzalez https://github.com/adrianluisgonzalez, any objections to adding vertx-rx-java support?

We could make it optional like you did the vertx-js

io.vertx vertx-rx-java ${vertx.version} true

— Reply to this email directly or view it on GitHub https://github.com/englishtown/vertx-elasticsearch-service/issues/20.

newoga commented 8 years ago

Hey @adrianluisgonzalez , sorry it's taken me a month for this pull request ( #22 ). We've been working on a forked branch over here and I forgot to create it.

All the rx related functionality was generated in package com.englishtown.vertx.rxjava.elasticsearch.

Hope all is well!