search

ef-labs / vertx-guice

Create Vert.x Modules and Verticles with dependency injection using Guice
MIT License
59 stars 24 forks source link

GuiceVerticleLoader needs to be updated for Vert.x 3.8.0. #19

Open dano opened 4 years ago

dano commented 4 years ago

In Vert.x 3.8.0, the Verticle method void start(Future<Void> startFuture) is deprecated in favor of void start(Promise<Void> startPromise). However, if you override that in a Verticle that you want to inject via vertx-guice, the start method will not be called, because GuiceVerticleLoader overrides void start(Future<Void> startFuture), and directly calls the same start method on your Verticle.

dano commented 4 years ago

Ah, I actually just noticed https://github.com/ef-labs/vertx-guice/pull/18 is already open that addresses this.

Kirik0u commented 4 years ago

Hi, will there be a version 2.3.2 including this changes ?