search

ef4 / decorator-transforms

Better babel transforms for decorators
8 stars 5 forks source link

no difference under embroider? (or I missed something!) #6

Closed NullVoxPopuli closed 10 months ago

NullVoxPopuli commented 10 months ago

Trying things out here: https://github.com/NullVoxPopuli/package-majors/pull/3#issuecomment-1825763430

This is a very small app (one route, < 10 components). but I'd expect at least byte-count changes with my handfull of decorators image

NullVoxPopuli commented 10 months ago

oh nevermind, I need to wait for https://github.com/embroider-build/embroider/pull/1673 to be released

NullVoxPopuli commented 10 months ago

fixed!

using the decorator-transforms on a tiny embroider app, It looks like I've lost about 44KB -- or about 9.4% of the total size.

This is impressive, because I'm barely using any decorators at all in this app. Just goes to show how impactful / devestating the property transforms are.

before/after proof here: https://github.com/NullVoxPopuli/package-majors/pull/3#issuecomment-1830378820