search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

fullPaths should be configurable #107

Closed timiyay closed 5 years ago

timiyay commented 8 years ago

I've just started experimenting with ember-browserify, and I've come across an issue where my built files leak system paths, such as in this issue: https://github.com/substack/node-browserify/issues/902

This library hardcodes the fullPaths option to true, for any non-production environments.

I need this to be configurable, as I use a staging environment, which should be treated like production in most respects.

Ideally, I would be able to use this library's existing config to do this, like so:

// config/environment.js
// (or wherever this config ends up: https://github.com/ef4/ember-browserify/issues/96)
var isProductionLikeBuild = ['production', 'staging'].indexOf(EmberApp.env()) > -1;

browserify: {
  fullPaths: !isProductionLikeBuild,
  extensions: ['.coffee'],
  transform: [
    ['caching-coffeeify', { global: true }]
  ]
}
timiyay commented 8 years ago

PR submitted: https://github.com/ef4/ember-browserify/pull/108

timiyay commented 5 years ago

Closing this issue as stale.