ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

ignoring files #111

Closed shaunc closed 7 years ago

shaunc commented 7 years ago

In order to test an addon, I would like to include a test dependency which indirectly requires an optional package not specified as a dependency.

I am getting the error:

Error: Cannot find module 'WNdb' from '/Volumes/Macintosh_HD/Users/shauncutts/src/ember-column-index/node_modules/natural/lib/natural/wordnet'
    at /Volumes/Macintosh_HD/Users/shauncutts/src/ember-column-index/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/Volumes/Macintosh_HD/Users/shauncutts/src/ember-column-index/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/Volumes/Macintosh_HD/Users/shauncutts/src/ember-column-index/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/Volumes/Macintosh_HD/Users/shauncutts/src/ember-column-index/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/Volumes/Macintosh_HD/Users/shauncutts/src/ember-column-index/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /Volumes/Macintosh_HD/Users/shauncutts/src/ember-column-index/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:111:15)

I tried adding

browserify: {
  ignore: ['WNdb'],
}

To tests/dummy/config/environment.js. However, it has no effect. Is there a way to get ember-browserify to ignore a file?

shaunc commented 7 years ago

1) ok -- for documentation purposes:

browserify: {
  ignoreMissing: ['WNdb'],
}

Is the correct syntax. Unfortunately it seems that ember-browserify can't load modules in addons unless they are specified as dependencies (even for testing?)... which I don't want to do because of addon bloat.