search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Error parsing code while looking for "npm:" imports #116

Closed musaffa closed 7 years ago

musaffa commented 7 years ago

After upgrading to ember 2.13 and switching to yarn, I get the following error:

Error: Error parsing code while looking for "npm:" imports: SyntaxError: Unexpected token (17:65)
    at Parser.pp.raise (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:943:13)
    at Parser.pp.unexpected (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:1503:8)
    at Parser.pp.expect (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:1497:26)
    at Parser.pp.parseExprList (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:643:12)
    at Parser.pp.parseSubscripts (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:240:29)
    at Parser.pp.parseExprSubscripts (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:219:15)
    at Parser.pp.parseMaybeUnary (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:197:19)
    at Parser.pp.parseExprOps (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:151:19)
    at Parser.pp.parseMaybeConditional (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:133:19)
    at Parser.pp.parseMaybeAssign (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/node_modules/acorn/dist/acorn.js:110:19)
    at importsFor (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/lib/stubs.js:75:11)
    at Stub.set (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/lib/stubs.js:31:25)
    at StubGenerator.<anonymous> (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/lib/stub-generator.js:57:33)
    at Array.forEach (native)
    at StubGenerator.build (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/lib/stub-generator.js:49:12)
    at /home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/broccoli-plugin/read_compat.js:93:34
    at tryCatch (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/rsvp/dist/rsvp.js:539:12)
    at invokeCallback (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/rsvp/dist/rsvp.js:554:13)
    at publish (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/rsvp/dist/rsvp.js:522:7)
    at flush (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/rsvp/dist/rsvp.js:2414:5)

The broccoli plugin was instantiated at: 
    at StubGenerator.Plugin (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/broccoli-plugin/index.js:7:31)
    at new StubGenerator (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/lib/stub-generator.js:19:10)
    at Class.postprocessTree (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-browserify/lib/index.js:81:31)
    at projectOrAddon.addons.reduce (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-cli/lib/utilities/addon-process-tree.js:6:25)
    at Array.reduce (native)
    at addonProcessTree (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-cli/lib/utilities/addon-process-tree.js:4:32)
    at EmberApp.addonPostprocessTree (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-cli/lib/broccoli/ember-app.js:586:12)
    at EmberApp.test (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-cli/lib/broccoli/ember-app.js:1136:29)
    at EmberApp.toArray (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-cli/lib/broccoli/ember-app.js:1671:63)
    at EmberApp.toTree (/home/musaffa/projects/facts-overlooked/facts-overlooked-web/node_modules/ember-cli/lib/broccoli/ember-app.js:1686:38)
willrax commented 7 years ago

made easier to fix in #117

Kerrick commented 7 years ago

FWIW, I got this error after upgrading to Ember CLI 2.13 without switching to yarn.

Even more curiously, when I get this error running ember s I'm able to make any change (even just a whitespace change) and when ember-cli sees the change and recompiles, it doesn't have this error anymore. :thinking:

Kerrick commented 7 years ago

@musaffa Did you change your Ember CLI Targets such that it Ember CLI might no longer be compiling ES7+ features? I noticed my instance of the issue was caused by Ember CLI serving async/await natively.

See also: #118, #119.

shanebruggeman commented 7 years ago

I'm also seeing this error after adding these options to my ember-cli-build:

    babel: {
          optional: ['es6.spec.symbols'],
          blacklist: [
                'es6.forOf',
                'regenerator',
                'es6.arrowFunctions',
                'es6.constants',
                'es6.blockScoping',
                'es6.templateLiterals'
           ]
    },
    'ember-cli-babel': {
          includePolyfill: true
    }

And I definitely am using async / await / generators in my code

stefanpenner commented 7 years ago

should be fixed in v1.1.14