search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Should we deprecate ember-browserify? #131

Closed ef4 closed 6 years ago

ef4 commented 6 years ago

In favor of ember-cli-cjs-transform? If that had existed first, I would not have created ember-browserify.

Are there use cases I'm missing where browserify does additional things people need?

cc @rwjblue

rwjblue commented 6 years ago

I am in favor of deprecating...

stefanpenner commented 6 years ago

:shipit:

stefanpenner commented 6 years ago

In favor of ember-cli-cjs-transform? If that had existed first, I would not have created ember-browserify.

Ya ^ was inspired by your work on ember-browserify.

ef4 commented 6 years ago

On a related note: it seems like maybe only a small amount of hacking to take ember-browserify's parsing step where it discovers imports and modify it so it matches module names against your NPM dependencies and automatically calls app.import with the cjs transform. This would complete the much requested "just import from NPM" feature.

ef4 commented 6 years ago

To answer my own question: it was very much not hard.