ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

it does not support scoped package (or I didn't find the way it handles it) #132

Closed ngouy closed 6 years ago

ngouy commented 6 years ago

I am unable to import scoped package

If i'm trying to do import EasyTemplate from 'npm:@ngouy/easy-template'; import EasyTemplate from 'npm:ngouy/easy-template'; import EasyTemplate from 'npm:easy-template'; `import EasyTemplate from 'npm:ngouy:easy-template'; It's never working

not working neither (I think it's because it's only on ember >= 3.x with) :

app.import('node_modules/@ngouy/easy-template/distribution/easy-template.js', {
     using: [
       { transformation: 'amd', as: 'easy-template.js' }
     ]

Ember : 2.8.3 Ember Data : 2.12.1 Ember cli : 2.11.1

stack error:

Build Canceled: Broccoli Builder ran into an error with CoreObject plugin. 💥 Cannot find module '@ngouy/easy-template' from '/Users/blabla/my-project/tmp/stub_generator-output_path-MFjPGmw4.tmp' Error: Cannot find module '@ngouy/easy-template' from '/Users/blabla/my-project/tmp/stub_generator-output_path-MFjPGmw4.tmp' at //Users/blabla/my-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17 at process (/Users/blabla/my-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43) at ondir (/Users/blabla/my-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17) at load (/Users/blabla/my-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43) at onex (/Users/blabla/my-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31) at /Users/blabla/my-project/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47 at FSReqWrap.oncomplete (fs.js:82:15)

ef4 commented 6 years ago

This package is being deprecated in favor of ember-auto-import. That one definitely works with scoped packages.

ngouy commented 6 years ago

Thank you, I missed this information: I used this since a long time.

Than you again for your amazing work

ef4 commented 6 years ago

It is hopefully a very simple upgrade (just removing "npm:" from your imports). And it will probably give you faster builds too.

ngouy commented 5 years ago

Just for the record, how do you use a scoped npm package ?

> ember -v
< ember-cli: 2.11.1
< node: 6.11.0

import { process } from '@ngouy/easy-template';

=> Can't resolve '@ngouy/easy-template' in '/Users/nathangouy/travail/due/www-dashboard'