search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Importing from intl-relativeformat is broken #15

Closed bobisjan closed 9 years ago

bobisjan commented 9 years ago

Hi,

I have installed both intl-messageformat and intl-relativeformat, they have same ./lib/main.js with same content, but only intl-messageformat has that file included.

screen shot 2015-01-13 at 21 45 42

It brokes the import IntlRelativeFormat from 'npm:intl-relativeformat';, because IntlRelativeFormat contains function MessageFormat from intl-messageformat.

node: 0.10.31 npm: 2.1.8 ember-cli: 0.1.6 ember-browserify: 0.6.0

Thanks

jasonmit commented 9 years ago

This looks to be an issue with browserify 6.x.x, and fixed in a later release: https://github.com/yahoo/react-intl/issues/84

@ef4 I can submit a PR to update browserify if you're opened to it.

ef4 commented 9 years ago

Sure, sounds good.

It seems plausibly like a browserify bug, because browserify does content-based deduplication, so two identical files in two different modules could be an edge case for them.

bobisjan commented 9 years ago

@jasonmit thanks, after update it works as expected.