ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Transforms don't load correctly when running `npm link`ed #21

Open ef4 opened 9 years ago

ef4 commented 9 years ago

We look up transform modules relative to ember-browserify, not relative to the user's app. This is only really an issue when running npm linked.

danny-andrews commented 8 years ago

I'm actually having an issue getting transforms to load at all. Specifically, browserify-shim. The transform function is only being passed the core_object-input_staging-6DY6kPE9.tmp/browserify_stubs.js file, and the stubbed define('npm:foo', function(){ return { 'default': require('foo')};}) code so it can't find (and replace) the require's inside my foo module.

danny-andrews commented 8 years ago

False alarm, I didn't realize browserify transforms only work one level deep.

stefanpenner commented 8 years ago

@ef4 still an issue?

ef4 commented 8 years ago

Yes. You can reproduce by configuring any babel transform and trying to build your app while ember-browserify is npm linked.

stefanpenner commented 8 years ago

related: https://github.com/ef4/ember-browserify/issues/16