search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

symlinkOrCopy.sync seems like it could remain async #3

Closed stefanpenner closed 9 years ago

stefanpenner commented 9 years ago

https://github.com/ef4/ember-browserify/blob/master/stub-generator.js#L42

unsure if this is good or bad, merely pointing it out.

rwjblue commented 9 years ago

@stefanpenner - There is no async version actually. If you invoke as symlinkOrCopy (without the .sync) it throws an error.

https://github.com/broccolijs/node-symlink-or-copy/blob/master/index.js#L8

stefanpenner commented 9 years ago

ah ok