Use acorn instead of esprima

[asakusuma]

Acorn is faster. Acorn also does not make git requests during build, which Esprima does. This is unpaletable for many companies that don't want out-of-datacenter network calls at build time.

http://esprima.org/test/compare.html http://marijnhaverbeke.nl/blog/acorn.html

[ef4]

Looks good to me, thanks Asa.

[devinus]

Perhaps you should use babel-core to parse (e.g. https://github.com/babel/babel-eslint/blob/master/index.js#L5) and pass in the app's babel configuration so that all valid ember-cli code is also valid ember-browserify code (e.g. computed decorators and everything else babel supports).

I believe this is why https://github.com/ef4/ember-browserify/issues/35 is happening to me.

[devinus]

Another example: https://github.com/babel/babel/blob/7407b37bd9cbde15c667b2dcf3a7b198ecfd14c8/test/core/generation.js#L29

[asakusuma]

Thanks @devinus I'll take a shot at a PR tomorrow

[asakusuma]

Actually @devinus your stack trace references esprima, not acorn, so I don't think this is related

[devinus]

@asakusuma Indeed, it was using Esprima, however the issue remains that it wont be able to parse anything that uses a Babel transform.