search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Make this work properly with in-repo-addons #38

Closed Awem closed 8 years ago

Awem commented 9 years ago

I haven't found a solution to make the following case work:

  1. Have ember-browserify installed via main package.json of the Ember-CLI-app
  2. Install a Node module via package.json of an in-repo-addon
  3. do import Module from "npm:module" in a file of the in-repo-addon

Result: Cannot find module

However, the same import command works, if you do not install that Node module via the in-repo-addon's but via the app's package.json. One would need to somehow specify the path to the in-repo-addon's Node modules, but I haven't found a way to do that.

asakusuma commented 9 years ago

Have you tried installing ember-browserify in the addon as well? Git repo structure should not have an effect, as long as the directory structure is the same.

Awem commented 9 years ago

No, I will try that. It might work, but I would prefer to use the main app's ember-browserify.

Awem commented 9 years ago

Installing ember-browserify in the addon as well, doesn't make a difference. I ran in a new issue, though: #39

asakusuma commented 9 years ago

@AW-UC were you able to get this working by installing the module in the root app?

Awem commented 9 years ago

yes, installing the module in the root app works well. Only the combination of:

  1. module in in-repo-addon
  2. ember-browserify in root app doesn't work.
asakusuma commented 8 years ago

Yes I believe that is expected. Closing.