search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Build error when installed as dependancy in in-repo-addon #39

Closed Awem closed 9 years ago

Awem commented 9 years ago

There's a build error when installed in an in-repo-addon. Steps to reproduce:

  1. generate an in-repo-addon
  2. npm install --save ember-browserify in-repo-addon directory
  3. ember server in app's directory

Result:

Error: Path or pattern "browserify/browserify.js" did not match any files

I know, that the install command is supposed to be npm install --save-dev ember-browserify. But, I think it should work nevertheless, because installing as dependancy instead of devDependancy:

  1. works fine in the main app
  2. would be the correct way to define, that the addon depends on ember-browserify installed in the main app`s scope
asakusuma commented 9 years ago

I believe this is a duplicate of https://github.com/ef4/ember-browserify/issues/34

ember-browserify has to be installed in both the parent app and the addon. It's a limitation of ember-cli.

Awem commented 9 years ago

@asakusuma correct! closing this one.