search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

No inputTree/inputTrees set on tree #44

Closed bambery closed 8 years ago

bambery commented 8 years ago

As soon as I ember install ember-browserify, my app will no longer start up. Uninstalling ember-browserify allows my app to function. Here's a snippet from my package.json:

"devDependencies": {
      "active-model-adapter": "1.13.6",
      "broccoli-asset-rev": "^2.0.2",
      "ember-browserify": "1.0.4",
      "ember-cli": "1.13.7",
      "ember-cli-app-version": "0.4.0",
      "ember-cli-babel": "^5.0.0",
      "ember-cli-content-security-policy": "0.4.0",
      "ember-cli-dependency-checker": "^1.0.0",
      "ember-cli-htmlbars": "0.7.9",
      "ember-cli-htmlbars-inline-precompile": "^0.1.1",
      "ember-cli-ic-ajax": "0.2.1",
      "ember-cli-inject-live-reload": "^1.3.0",
      "ember-cli-qunit": "0.3.20",
      "ember-cli-release": "0.2.3",
      "ember-data": "1.13.7",

The following error is provided:

No inputTree/inputTrees set on tree: CoreObject Error: No inputTree/inputTrees set on tree: CoreObject at NewStyleTreeWrapper.read (/Users/lwszolek/repos/ember/borrowers/node_modules/ember-cli/node_modules/broccoli/lib/api_compat.js:27:11) at /Users/lwszolek/repos/ember/borrowers/node_modules/ember-cli/node_modules/broccoli/lib/builder.js:98:23 at lib$rsvp$$internal$$tryCatch (/Users/lwszolek/repos/ember/borrowers/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:493:16) at lib$rsvp$$internal$$invokeCallback (/Users/lwszolek/repos/ember/borrowers/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:505:17) at /Users/lwszolek/repos/ember/borrowers/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1001:13 at lib$rsvp$asap$$flush (/Users/lwszolek/repos/ember/borrowers/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1198:9) at process._tickCallback (node.js:355:11)

Fryie commented 8 years ago

I have the same error (still using Ember 1.12)

Fryie commented 8 years ago

Seems to be a regression in the 1.0.4 release. Downgrading to 1.0.3 works for me. So it has to be this update that somehow breaks at least in some cases: https://github.com/ef4/ember-browserify/commit/35f6cfe9fb39e4563853d900d6104c606715eef1

artych commented 8 years ago

Same on ember-cli: 1.13.8. Downgrading to 1.0.3 fixes error.

stefanpenner commented 8 years ago

https://github.com/ef4/ember-browserify/blob/master/lib/caching-browserify.js doesn't call super in the constructor.

Cc @asakusuma

rwjblue commented 8 years ago

I am curious how the tests pass after https://github.com/ef4/ember-browserify/commit/35f6cfe9fb39e4563853d900d6104c606715eef1. It seems like they would have the same issue....

stefanpenner commented 8 years ago

@rwjblue they don't.

CI likely would have caught this

@ef4 / @asakusuma I'm not admin on this repo, can you guys

ef4 commented 8 years ago

I'm on it.

ef4 commented 8 years ago

1.0.5 released.

CI was already enabled. https://travis-ci.org/ef4/ember-browserify/builds

stefanpenner commented 8 years ago

Ah it appears 35f6cfe went straight to master.

stefanpenner commented 8 years ago

i have proposed adding the travis badge to the readme https://github.com/ef4/ember-browserify/pull/45

asakusuma commented 8 years ago

Sorry about all this, my fault.

On the plus side, this exposed a false positive bug in our internal hudson tooling...