search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

PostProccess No Longer Receives Modules #46

Closed chadhietala closed 8 years ago

chadhietala commented 8 years ago

We will be removing esperanto and slightly modify the flow of trees. PostProcess hook will now recieve a fully preprocessed tree instead of one that was only partially processed.

While these changes have been verfiied in a real app, we loose the ability to throw when a dev attempts to use a named import.

Please see https://github.com/ember-cli/ember-cli/pull/4764 for more details about the changes that effect this addon.

asakusuma commented 8 years ago

Just to clarify for everyone else, this is only for ember-cli 2.x. It's backwards incompatible with ember-cli 1.x. We'll have to either do a major version bump, or have some sort backcompat logic.

chadhietala commented 8 years ago

The Ember-CLI changes have been merged https://github.com/ember-cli/ember-cli/pull/4792

asakusuma commented 8 years ago

Closing in favor of https://github.com/ef4/ember-browserify/pull/49