search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Cannot read property 'name' of undefined #5

Closed burgalon closed 9 years ago

burgalon commented 9 years ago

Followed the instructions in the readme. Using ember-cli 0.1.3 Tried npm install --save-dev uniq import uniq from "npm:uniq"

Here's the error I'm getting on ember-cli

TypeError: Cannot read property 'name' of undefined
  at ExportDeclaration.enter ($project/node_modules/ember-browserify/node_modules/petal/lib/visitors/export-declaration.js:14:60)
  at Object.traverse.enter ($project/node_modules/ember-browserify/node_modules/petal/lib/petal.js:126:17)
  at traverse ($project/node_modules/ember-browserify/node_modules/petal/node_modules/es-simpler-traverser/index.js:6:15)
  at traverse ($project/node_modules/ember-browserify/node_modules/petal/node_modules/es-simpler-traverser/index.js:15:7)
  at traverse ($project/node_modules/ember-browserify/node_modules/petal/node_modules/es-simpler-traverser/index.js:15:7)
  at Petal._walk ($project/node_modules/ember-browserify/node_modules/petal/lib/petal.js:113:3)
  at new Petal ($project/node_modules/ember-browserify/node_modules/petal/lib/petal.js:45:10)
  at gatherStubs ($project/node_modules/ember-browserify/stub-generator.js:68:15)
  at $project/node_modules/ember-browserify/stub-generator.js:31:11
  at Array.forEach (native)
  at $project/node_modules/ember-browserify/stub-generator.js:29:13
  at $$$internal$$tryCatch ($project/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:470:16)
  at $$$internal$$invokeCallback ($project/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:482:17)
  at $$$internal$$publish ($project/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:453:11)
  at $$rsvp$asap$$flush ($project/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1531:9)
  at process._tickCallback (node.js:419:13)
ef4 commented 9 years ago

I tried to reproduce this but couldn't. From the stack trace it looks like petal (used by ember-browserify) had trouble parsing something inside uniq. What version of uniq?

ef4 commented 9 years ago

I think this issue is fixed in ember-browserify 0.3.0. We no longer depend on petal, and this was a petal crash.