search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

fix internal requires #61

Closed calvinmetcalf closed 8 years ago

calvinmetcalf commented 8 years ago

basically ember breaks if there are internal calls to require inside of an app, why would a dependency have that? well it would if someone pointed their package.json main field to a bundle they made with browserify. This should fix that by renaming all require uses that are internal.

ef4 commented 8 years ago

Thanks. I'm fine with adding derequire to the pipeline. Can you please see why CI failed?

calvinmetcalf commented 8 years ago

ok updated the .travis.yml, then merged in your changes and realized you updated the .travis.yml so I merged in my addtions of updating to the latest npm and testing against latest node in addition to the one you were testing against looks green now

asakusuma commented 8 years ago

Awesome, thanks! Will release a new version shortly.