search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

The package asn1.js does not satisfy its siblings' peerDependencies requirements! #7

Closed oddnavy closed 8 years ago

oddnavy commented 9 years ago

On a fresh install of ember cli if I try to install ember-browserify I get the above error

ef4 commented 9 years ago

(^ I didn't mean to close this. I will investigate.)

stefanpenner commented 8 years ago

asn1 appears to explicitly bypass browserify here for the jszip asset, and seems to scan for it globally. If you provide it as a manually dependency i suspect it works. Unfortunately not something I think this lib can handle automatically...

// from the browserified output
if(typeof JSZip !== 'undefined') jszip = JSZip;
if (typeof exports !== 'undefined') {
    if (typeof module !== 'undefined' && module.exports) {
        if(has_buf && typeof jszip === 'undefined') jszip = require('js'+'zip');
        if(typeof jszip === 'undefined') jszip = require('./js'+'zip').JSZip;
        _fs = require('f'+'s');
    }
}