search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Prevent watching parent directories of project root #71

Closed trentmwillis closed 8 years ago

trentmwillis commented 8 years ago

In working on a custom task that builds an Ember project from outside its root directory, I was getting infinite rebuilds while using this addon. The root cause is that the process' cwd is different from the project's root, which meant that it wound up getting "watched". Since the project is a child of this watched directory, it would rebuild anytime anything changed.

I propose to fix this issue by making sure that the watched dir is not equal to or a starting portion of the project's root.

cc @asakusuma

asakusuma commented 8 years ago

Thanks. @trentmwillis verified that this works in a couple different apps.