Refactor stub generator

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.

MIT License

172 stars 28 forks source link

Refactor stub generator #75

Closed stefanpenner closed 8 years ago

stefanpenner commented 8 years ago

[x] make work
[x] address todos
[x] do a thorough perf check (10%->20% rebuild improvements in my app, when no browserify stuff changes)
[x] add tests to cover perf related semantics
[x] unit test new Stub class

ef4 commented 8 years ago

You now have commit and npm publish bits.

stefanpenner commented 8 years ago

@asakusuma / @ef4 would like r? and if you have time to give it a whirl in your apps.

asakusuma commented 8 years ago

@stefanpenner thanks, I'll review and give it a whirl tomorrow

ef4 commented 8 years ago

I smoke tested in an app, everything looks ok.

stefanpenner commented 8 years ago

I'm most likely going to work on the other plugin next, but i'll likely do so in another PR.

asakusuma commented 8 years ago

@stefanpenner debug still needs to be added to package.json, but other than that, looks good. I tested it out in our largest app and it worked fine.

stefanpenner commented 8 years ago

@asakusuma done

stefanpenner commented 8 years ago

@asakusuma also disregard appveyor for now, we haven't actually gotten it working yet. This should be good to go.

starting appveyor stuff -> https://github.com/ef4/ember-browserify/pull/78

stefanpenner commented 8 years ago

As this passes in my apps, @ef4 and @asakusuma I think its good to merge. I got some more work planned for this this weekend, so i'm planning to release once thats done. But if someone is craving this sooner, feel free to release.