search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

old browserify #77

Closed stefanpenner closed 8 years ago

stefanpenner commented 8 years ago

It seems like updating changes a bit of the hard-coded test output, but works fine. Any objection to an upgrade?

ef4 commented 8 years ago

:+1:

asakusuma commented 8 years ago

Upgrade seems good

ProLoser commented 8 years ago

This has become critical for me because the current version of browserify for WHATEVER reason completely fails when using babelify and babel-plugin-transform-es2015-classes

Serving on http://localhost:4200/
/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/combine-source-map/node_modules/inline-source-map/node_modules/source-map/lib/source-map/source-map-generator.js:275
        throw new Error('Invalid mapping: ' + JSON.stringify({
        ^

Error: Invalid mapping: {"generated":{"line":19,"column":11},"source":"test.js","original":{},"name":null}
    at SourceMapGenerator_validateMapping [as _validateMapping] (/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/combine-source-map/node_modules/inline-source-map/node_modules/source-map/lib/source-map/source-map-generator.js:275:15)
    at SourceMapGenerator_addMapping [as addMapping] (/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/combine-source-map/node_modules/inline-source-map/node_modules/source-map/lib/source-map/source-map-generator.js:105:14)
    at /Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/combine-source-map/node_modules/inline-source-map/index.js:40:15
    at Array.forEach (native)
    at Generator.addMappings (/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/combine-source-map/node_modules/inline-source-map/index.js:38:12)
    at Combiner._addExistingMap (/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/combine-source-map/index.js:33:18)
    at Combiner.addFile (/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/combine-source-map/index.js:58:12)
    at Transform.write [as _transform] (/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/index.js:63:23)
    at Transform._read (/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at Transform._write (/Users/dsofer/Sites/testing/node_modules/ember-browserify/node_modules/browserify/node_modules/browser-pack/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:12)

Upgrading the internally used version of browserify of this plugin fixed everything. This has been blocking me for a week until I looked into this comment: http://stackoverflow.com/questions/36798651/gulp-task-react-invalid-mapping-error#comment61303123_36798651.

asakusuma commented 8 years ago

@ProLoser just released 1.1.9 which has the browserify upgrade