Decouple tests - Githubissues

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.

MIT License

172 stars 28 forks source link

Decouple tests #82

Closed stefanpenner closed 8 years ago

stefanpenner commented 8 years ago

we should test the function output, not byte/byte output.
test that loading a file introduces the correct modules
leave testing browserify to browserify
[x] get feedback
[x] finish
[x] test source-maps existence.

stefanpenner commented 8 years ago

oops, will fix tests

stefanpenner commented 8 years ago

looks like the failing test is related to node 6, and how I'm releasing modules on reload

stefanpenner commented 8 years ago

looks like the failing test is related to node 6, and how I'm releasing modules on reload

looks to be a easy fix, seems like node 6 stores the path used to require, and earlier versions store the realpath of them. I suspect they changed this because realpath is more costly? Anyways, I know merely evict both. Locally the issues are addressed, lets see what CI says

asakusuma commented 8 years ago

looks awesome, learned a few things things reading the diff. not having to update the expected files is gonna be real nice

ef4 commented 8 years ago

:clap: