ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Breaks with broccoli-caching-writer@0.5.4 #9

Closed lsocrate closed 9 years ago

lsocrate commented 9 years ago

I updated the project and got the following breakage, which after some investigation I found to be caused by the dependency broccoli-caching-writer being updated to version 0.5.4

version: 0.1.4
valid watchman found, version: [3.0.0]
Proxying to http://localhost:3000
Livereload server on port 35729
Serving on http://0.0.0.0:4200/
Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
    at promiseMapSeries (/home/lsocrate/Projects/touchdown/t/touchdown-cli/node_modules/ember-browserify/node_modules/promise-map-series/index.js:4:32)
    at CoreObject.proto.read (/home/lsocrate/Projects/touchdown/t/touchdown-cli/node_modules/ember-browserify/node_modules/broccoli-caching-writer/index.js:74:10)
    at CoreObject.module.exports.CachingWriter.extend.read (/home/lsocrate/Projects/touchdown/t/touchdown-cli/node_modules/ember-browserify/caching-browserify.js:18:29)
    at /home/lsocrate/Projects/touchdown/t/touchdown-cli/node_modules/ember-cli/node_modules/broccoli/lib/builder.js:79:23
    at $$$internal$$tryCatch (/home/lsocrate/Projects/touchdown/t/touchdown-cli/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:470:16)
    at $$$internal$$invokeCallback (/home/lsocrate/Projects/touchdown/t/touchdown-cli/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:482:17)
    at /home/lsocrate/Projects/touchdown/t/touchdown-cli/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1066:13
    at $$rsvp$asap$$flush (/home/lsocrate/Projects/touchdown/t/touchdown-cli/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1531:9)
    at process._tickCallback (node.js:419:13)
ef4 commented 9 years ago

Thanks for reporting, I actually released a fix for this just in the last hour.

https://github.com/ef4/ember-browserify/issues/8