search

ef4 / ember-browserify

ember-cli addon for easily loading CommonJS packages from npm via browserify.
MIT License
172 stars 28 forks source link

Removes redundant check #95

Closed twokul closed 7 years ago

twokul commented 7 years ago

Some of the child addons (the ones that consume ember-browserify) start breaking after upgrading to 2.7.0. This fixes failures.

stefanpenner commented 7 years ago

@ef4 / @asakusuma r?

asakusuma commented 7 years ago

@stefanpenner lgtm, but isn't this the same general approach as https://github.com/ef4/ember-browserify/pull/93? And if so, does the same deduping question need to be answered?

twokul commented 7 years ago

@asakusuma I somehow missed that PR. I feel like deduping is a pandora's box and requires a different PR/conversation all together.

/cc @stefanpenner

asakusuma commented 7 years ago

@twokul I agree that this is a separate issue, but I defer to @stefanpenner since he raised the issue in the first place.

twokul commented 7 years ago

@asakusuma 👍 👌

stefanpenner commented 7 years ago

@twokul did you do the deeper investigation we discussed in-person.

We discovered that basically the scenario described most likely does not work in the first case, this merely prevents it from exploding but does not address the underlying issue.