search

ef4 / ember-elsewhere

Render elsewhere in the DOM, with nice composition, animation, etc. Based on 100% public API.
MIT License
184 stars 25 forks source link

fastboot compat #13

Closed davidpett closed 7 years ago

davidpett commented 7 years ago

default initialized: true when in FastBoot mode. changed willRender to didReceiveAttrs to ensure the template is rendered when in FastBoot

ef4 commented 7 years ago

Thanks @davidpett, sorry this lingered, I just caught up and found it.

davidpett commented 7 years ago

thanks, will a new release be cut?

kaspiCZ commented 7 years ago

This didn't work for us when we tried to update. Even tried FastBoot beta14 to be on the same page. However wrapping ember-elsewhere/addon/services/ember-elsewhere.js:27 in a isFastBoot check and running this._process() right away in FastBoot made it work. Like so:

_schedule() {
    if (this.get('fastboot.isFastBoot')) {
      this._process();
    } else {
      run.scheduleOnce('afterRender', this, this._process);
    }
  },

There's either something we borked on our end or any other ideas?